search

databricks / spark-sql-perf

Apache License 2.0
586 stars 407 forks source link

Update Scala Logging to officially supported one #157

Closed mrow4a closed 6 years ago

mrow4a commented 6 years ago

Description

Scala logging slf4j (https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging-slf4j) is no longer supported (since 2014). I have also started receiving conflicts between packages since this one is using legacy one.

Update to maintained solves the issue https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging

How did I test?

I run TPCDS benchmark with Spark both on YARN/HDFS and Kubernetes/S3.

CC: @prasanthkothuri

juliuszsompolski commented 6 years ago

cc @npoggi, looks good to me.

NMigo commented 6 years ago

@mrow4a looks good, will test it next time we do a new build.

mrow4a commented 6 years ago

@NMigo thanks!