databricks / spark-sql-perf

Apache License 2.0
586 stars 407 forks source link

Fix 3 local benchmark classes #165

Closed g1thubhub closed 6 years ago

g1thubhub commented 6 years ago

This PR fixes broken benchmarks so that 'AggregationPerformance' and 'JoinPerformance' can be run (they don't work currently) and the average benchmark for Datasets in 'DatasetPerformance' work. I ran all benchmarks with those fixes successfully and all changes below are necessary -- for example, without the explicit type annotation ": Seq[Benchmarkable]" the benchmarks did not work on my computer likely due to some compiler/reflection hiccups

juliuszsompolski commented 6 years ago

cc @npoggi

g1thubhub commented 6 years ago

Added an explanation and usage info to the ReadMe, let me know if something is still missing or should be changed

npoggi commented 6 years ago

Merging, Travis test errors are related to 2.4-SNAPSHOT availability