Updates for scala 2.12 compatibility

databricks / spark-sql-perf

Apache License 2.0

582 stars 406 forks source link

Updates for scala 2.12 compatibility #176

Closed LucaCanali closed 5 years ago

LucaCanali commented 5 years ago

This PR adds a few updates and minor changes to

allow compiling with scala 2.12
running with the current (January 2019) Spark master
update usage of logging

This PR has been manually tested with a few sample runs of TPCDS and TPCH benchmark on a YARN cluster.

npoggi commented 5 years ago

From the first tests on our platform seems to work fine both on spark 3 and previous versions. Will let running some other tests during the weekend. @mengxr do you see any potential conflicts in the code changes to the ML benchmarks?

npoggi commented 5 years ago

@yhuai could you do a quick review of the code?

yhuai commented 5 years ago

lgtm