search

databricks / spark-sql-perf

Apache License 2.0
582 stars 406 forks source link

Removes labels from tree data generation #82

Closed thunterdb closed 7 years ago

thunterdb commented 8 years ago

Note: it builds upon #81 , which should be reviewed first.

thunterdb commented 8 years ago

It actually needs to be added at a different place. WIP.

jkbradley commented 8 years ago

LGTM, thanks for realizing this. Not sure why tests seemed to pass locally. Maybe it's just unclear to me how to check for whether things pass; is that documented anywhere, or is it just buried in logs which get deleted after the tests run? (I recall I had to hack the test to make it die and not delete the logs before exiting.)

jkbradley commented 8 years ago

Now it LGTM! Though I have not tested it myself