kduvekot-wehkamp-nl commented 3 years ago

I am not a scala programmer .. but based on what I see in this file .. and the build error .. this might solve it

codecov-commenter commented 3 years ago

Codecov Report

Merging #536 (60686a7) into master (2ba6736) will decrease coverage by 0.15%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   86.00%   85.84%   -0.16%     
==========================================
  Files          18       18              
  Lines         950      954       +4     
  Branches       84       81       -3     
==========================================
+ Hits          817      819       +2     
- Misses        133      135       +2

Impacted Files	Coverage Δ
...in/scala/com/databricks/spark/xml/XmlOptions.scala	`94.73% <50.00%> (-5.27%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1aab3c...60686a7. Read the comment docs.

kduvekot-wehkamp-nl commented 3 years ago

I have added some additional test to check for the angle brackets .. based on the code that was already there for other checks. I hope it's correct .. let's wait and see what codecov thinks when it picks things up.

kduvekot-wehkamp-nl commented 3 years ago

Travis-CI thinks it is fine .. and building correctly

https://travis-ci.org/github/databricks/spark-xml/builds/769309249

srowen commented 3 years ago

Oops, yeah I am having trouble getting Travis to trigger, and this seemed so trivial that I just merged it. My max line in my IDE isn't the same as in the linter. It's trivial but a test is fine, sure.

databricks / spark-xml

fix line length build error + add additional tests #536

Codecov Report