databricks / spark-xml

XML data source for Spark SQL and DataFrames
Apache License 2.0
505 stars 227 forks source link

Dummy change to test CI/CD. Not to be merged. #544

Closed srowen closed 3 years ago

srowen commented 3 years ago

@HyukjinKwon please don't spend any significant time on this, but I thought you might know - I recently committed changes to this repo to use Github actions to test. They don't seem to be working. Do you see any issue with how https://github.com/databricks/spark-xml/blob/master/.github/workflows/test_spark_3_java_11.yml is declared, off the top of your head?

HyukjinKwon commented 3 years ago

oh, IIRC $default-branch can only be used when running the shell (instead of defining workflow itself). let me make a quick try.

HyukjinKwon commented 3 years ago

oh no, that's updated at https://github.blog/changelog/2020-07-22-github-actions-better-support-for-alternative-default-branch-names/ so we can use $default-branch, hm. okay but that seems not supposed to be used in the actual workflow (https://github.community/t/default-branch-not-working/174392/2)

HyukjinKwon commented 3 years ago

Made a PR at https://github.com/databricks/spark-xml/pull/545. let me close this one :-).

srowen commented 3 years ago

Just reopening to test --