databricks / sqltools-databricks-driver

SQLTools driver for Databricks SQL
Other
11 stars 3 forks source link

Personal Access Token Stored in Plain Text #44

Closed DOH-WLD0303 closed 1 year ago

DOH-WLD0303 commented 1 year ago

First, I want to say thanks to the team for putting this tool together. I'm really impressed with it on first impression and looking forward to seeing it continue to be built out!

I noticed after setting up the tool in vscode, that the personal access token I had provided is being store din plain text in the .vscode/settings.json file. Not sure if there's a good way around that but it seems like it would be ideal to avoid storing it in plain text where it could easily make it to github.

fjakobs commented 1 year ago

Thanks for reporting the issue. For the first release we followed the SQLTools driver template but I agree that having the PAT in plain text is less than ideal.

Something I want us to fix in the future.