search

databricks / tensorframes

[DEPRECATED] Tensorflow wrapper for DataFrames on Apache Spark
Apache License 2.0
750 stars 162 forks source link

Change org.scalactic to testDependencies #157

Closed lu-wang-dl closed 5 years ago

lu-wang-dl commented 5 years ago

Change the lib dependency for scalactic. Move it from nonShadedDependencies to testDependencies

jkbradley commented 5 years ago

The code change LGTM. Would you mind building the JAR, using jar -tf to check to make sure scalactic classes are not included in the main JAR, and confirming that here?

lu-wang-dl commented 5 years ago

@jkbradley I double checked the assembly JAR file. There is no scalactic class anymore.

jkbradley commented 5 years ago

Thanks! Merging with master