databricks / terraform-databricks-examples

Examples of using Terraform to deploy Databricks resources
https://registry.terraform.io/modules/databricks/examples/databricks/latest
Other
187 stars 116 forks source link

Adding AWS Multiple Workspace Example #108

Closed JDBraun closed 5 months ago

JDBraun commented 7 months ago

This example provides a functioning AWS multiple workspace example.

Included in this example are:

In addition: Reference Images: These reference images include real screenshots as well as logical architecture diagrams of the set-up tfvars Examples: To expedite adoption of this example, we've provided tfvars examples that can be copied and applied into the repo

Further improvements:

JDBraun commented 6 months ago

Let's structure it differently - modules will go to the top-level modules folder, and then in examples we'll just show how to call these modules.

@alexott if I'm reading this correctly:

is that how you were imaging it?

alexott commented 6 months ago

@JDBraun I meant to have correct structure inside the repository, like this:

examples/
  aws-multi-workspace
     README.md
     *.tf files
modules/
  aws-module1
     README.md
     main.tf
     ...
  aws-module2
     README.md
     main.tf
     ...

images could be placed in the subdirectories of examples or in modules...

I've tried to talk about this layout in this PR: https://github.com/databricks/terraform-databricks-examples/pull/111/files

JDBraun commented 6 months ago

@JDBraun I meant to have correct structure inside the repository, like this:

examples/
  aws-multi-workspace
     README.md
     *.tf files
modules/
  aws-module1
     README.md
     main.tf
     ...
  aws-module2
     README.md
     main.tf
     ...

images could be placed in the subdirectories of examples or in modules...

I've tried to talk about this layout in this PR: https://github.com/databricks/terraform-databricks-examples/pull/111/files

Got it, thanks! I'll go ahead and take another stab at restructuring