search

databricks / terraform-databricks-examples

Examples of using Terraform to deploy Databricks resources
https://registry.terraform.io/modules/databricks/examples/databricks/latest
Other
187 stars 116 forks source link

Update ADB Unity Catalog metastore example #34

Closed hwang-db closed 1 year ago

hwang-db commented 1 year ago

A few minor readme changes and parameter changes on examples/adb-uc folder's stage 3 directory.

nkvuong commented 1 year ago

May worth waiting for the account-level API (preview right now) so we can simplify this example

On Sun, 12 Mar 2023, 12:39 Hao Wang, @.***> wrote:

@.**** commented on this pull request.

In examples/adb-uc/stage_3_spn_deploys_uc/terraform.tfvars https://github.com/databricks/terraform-databricks-examples/pull/34#discussion_r1133247794 :

@@ -1 +1 @@ -databricks_resource_id = "/subscriptions/3e551f82-c624-4a3e-b8f6-e050a96a7004/resourceGroups/testrg/providers/Microsoft.Databricks/workspaces/ws1" +databricks_resource_id = "/subscriptions/3e551f82-c624-4a3e-b8f6-e050a96a7004/resourceGroups/hwang-demo-rg/providers/Microsoft.Databricks/workspaces/demo-adb-ws"

thanks @alexott https://github.com/alexott , this folder directly piece together the code blocks in tf guide - https://registry.terraform.io/providers/databricks/databricks/latest/docs/guides/unity-catalog-azure where the resource_id of workspace is fed as input, and if I use data source again it will introduce a loop.

Shall I restructure it and use TF to spin up a workspace to feed these attributes instead of relying on data?

— Reply to this email directly, view it on GitHub https://github.com/databricks/terraform-databricks-examples/pull/34#discussion_r1133247794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKR5WRXP2P5BFWZRUWYMKXTW3W7Z3ANCNFSM6AAAAAAVYCPAHY . You are receiving this because your review was requested.Message ID: @.*** .com>

hwang-db commented 1 year ago

thanks @nkvuong , will wait for it; closing this PR.