databricks / terraform-databricks-examples

Examples of using Terraform to deploy Databricks resources
https://registry.terraform.io/modules/databricks/examples/databricks/latest
Other
187 stars 116 forks source link

add Overwatch multi-workspace deployment on Azure #55

Closed ayoubbenz-db closed 7 months ago

ayoubbenz-db commented 1 year ago

Thank you @alexott for your reviews. I changed the code accordingly :)

csimplestring commented 1 year ago

Hi this is a very good example to follow for Overwatch, is this PR ready?

ayoubbenz-db commented 1 year ago

Hi this is a very good example to follow for Overwatch, is this PR ready? @csimplestring I believe this PR is ready for use. Please let me know if you want us to sync on this

ayoubbenz-db commented 11 months ago

We need to rework this:

  • Split module into different modules

    • module for setting up overwatch workspace
    • module for deployment of overwatch into the workspace (so we can use existing workspace if necessary)
    • module for configuring regional things - eventhubs namespace, storage account for logs
    • module for configuring existing workspace to produce overwatch data - EH topic, mount, PAT, ...
  • CSV file should be generated from the list of declared workspaces

Cc: @yessawab

Done

alexott commented 8 months ago

@ayoubbenz-db for some reason it's blocked with Push cannot contain secrets - do you see any message on your side when doing the push?

ayoubbenz-db commented 8 months ago

@alexott no I don't see any message on my side. I also checked and I do not see any hardcoded secrets