Closed ayoubbenz-db closed 7 months ago
Hi this is a very good example to follow for Overwatch, is this PR ready?
Hi this is a very good example to follow for Overwatch, is this PR ready? @csimplestring I believe this PR is ready for use. Please let me know if you want us to sync on this
We need to rework this:
Split module into different modules
- module for setting up overwatch workspace
- module for deployment of overwatch into the workspace (so we can use existing workspace if necessary)
- module for configuring regional things - eventhubs namespace, storage account for logs
- module for configuring existing workspace to produce overwatch data - EH topic, mount, PAT, ...
- CSV file should be generated from the list of declared workspaces
Cc: @yessawab
Done
@ayoubbenz-db for some reason it's blocked with Push cannot contain secrets
- do you see any message on your side when doing the push?
@alexott no I don't see any message on my side. I also checked and I do not see any hardcoded secrets
Thank you @alexott for your reviews. I changed the code accordingly :)