databricks / terraform-databricks-sra

The Security Reference Architecture (SRA) implements typical security features as Terraform Templates that are deployed by most high-security organizations, and enforces controls for the largest risks that customers ask about most often.
Other
57 stars 27 forks source link

Updates to docs, removing unneeded flags, updating buckets #66

Closed JDBraun closed 1 month ago

JDBraun commented 2 months ago

This PR address the following issues:

Most notably, the external location and data bucket are no longer required given the fact that catalog isolation has been implemented.

JDBraun commented 2 months ago

@ryan-gord-db - great catch, updated!

JDBraun commented 1 month ago

@metrocavich - updated in new commit, let me know

I took this and applied to all the optional variables of enabling certain features

metrocavich commented 1 month ago

Left a react but forgot to comment, makes a lot more sense to me, thanks for humoring me.

JDBraun commented 1 month ago

@metrocavich - let me know if you have anything else or will get it merged

metrocavich commented 1 month ago

This looks all fantastic to me now. Very nice work.