Closed zgcalebp closed 1 week ago
And please do make fmt
Sorry for the typos on that last commit 😅 . Working through getting these integration tests to run locally now. Thanks for the quick review too!
Was able to validate the MR updates locally, should be good to merge upon review and Git action completions. Let me know if any further input is needed!
Thanks @alexott for the test update. Should've more strongly considered the provisioning time for a permissions test.
It's very specific for vector search endpoint - I realised that test was running too long, and made the update. I'll merge as soon as tests are passing
thank you for your contribution!
Is there some way to view the output of the integration tests? Surprised they aren't passing, happy to update to fix.
@zgcalebp The tests were failing because I ran the original patch with full-blown permissions test, but VS requires UC, and the test name wasn't adjusted for running only on UC-enabled workspaces
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:
Trigger: go/deco-tests-run/terraform
Inputs:
81605c2aa8673d2f0c7eedae14deeba3276748f1
Checks will be approved automatically on success.
Test Details: go/deco-tests/11813686757
Changes
Databricks permissions API has been updated to support
vector-search-endpoints
. This corresponding change to the permissions_definitions would enable the use of thedatabricks_permissions
resource to manage ACLs for Vector Search Endpoints leveraging the existing APIs under the hood.Example CLI call confirming support:
Tests
make test
run locallydocs/
folderinternal/acceptance