search

databricks / terraform-provider-databricks

Databricks Terraform Provider
https://registry.terraform.io/providers/databricks/databricks/latest
Other
456 stars 393 forks source link

[Fix] Remove single-node validation from jobs clusters #4216

Closed shreyas-goenka closed 1 week ago

shreyas-goenka commented 1 week ago

Changes

Fixes https://github.com/databricks/cli/issues/1896. Introducing this validation has caused a regression for both DABs and TF customers. This PR removes the validation for job clusters.

Tests

Unit tests.

alexott commented 1 week ago

Do we still need #4206?

pietern commented 1 week ago

@shreyas-goenka Please update this as well: https://github.com/databricks/terraform-provider-databricks/blob/e3b25617d9c9357eccc10fba2eacbd26ac3e7118/clusters/resource_cluster.go#L133-L135

@tanmay-db Can you confirm if this aligns with the direction you're taking for these resources?

shreyas-goenka commented 1 week ago

@alexott Yeah we still need https://github.com/databricks/terraform-provider-databricks/pull/4206 since it tackles the issue of policy not working from clusters. I need to update that PR however.

github-actions[bot] commented 1 week ago

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger: go/deco-tests-run/terraform

Inputs:

Checks will be approved automatically on success.

eng-dev-ecosystem-bot commented 1 week ago

Test Details: go/deco-tests/11815755779

tanmay-db commented 1 week ago

@shreyas-goenka Please update this as well:

https://github.com/databricks/terraform-provider-databricks/blob/e3b25617d9c9357eccc10fba2eacbd26ac3e7118/clusters/resource_cluster.go#L133-L135

@tanmay-db Can you confirm if this aligns with the direction you're taking for these resources?

Hi @pietern, yes this would be implemented a bit differently in plugin framework so it should be good. Eventually we will remove the cluster resource in SDKv2 so there would only be one place where validation would happen.