search

databricks / terraform-provider-databricks

Databricks Terraform Provider
https://registry.terraform.io/providers/databricks/databricks/latest
Other
454 stars 392 forks source link

[ISSUE] Enabled `skip_validation` in `databricks_instance_profile` doesn't skip diff #860

Closed BenMcClainCarpe closed 3 years ago

BenMcClainCarpe commented 3 years ago

Configuration

resource "databricks_instance_profile" "instance_role" {
  provider = databricks.created_workspace
  depends_on = [
    aws_iam_role_policy.s3_policy,
    aws_iam_role_policy.instance_profile_permissions,
    databricks_mws_workspaces.this
  ]
  instance_profile_arn = aws_iam_instance_profile.instance_role.arn
  skip_validation = true
}

Expected Behavior

Apply Terraform for the first time, it creates the instance profile within the workspace. (This works great!) When running it again without any changes, it should show that this instance profile has no changes.

Actual Behavior

When running Terraform apply again without changes, it tries to modify the instance profile resource in the below way:

  # databricks_instance_profile.instance_role will be updated in-place
  ~ resource "databricks_instance_profile" "instance_role" {
        id                       = "arn:aws:iam::694017378957:instance-profile/sdlc-devops-us-west-2-20211012221409208600000001"
      ~ skip_validation          = false -> true
        # (2 unchanged attributes hidden)
    }

APPROVE

Error: doesn't support update

  on instance_iam.tf line 40, in resource "databricks_instance_profile" "instance_role":
  40: resource "databricks_instance_profile" "instance_role" {

Steps to Reproduce

  1. Have an databricks_instance_profile resource in your Terraform code.
  2. Run it with terraform apply
  3. Run it again with terraform apply

Terraform and provider versions

Terraform v0.14.5

Your version of Terraform is out of date! The latest version is 1.0.9. You can update by downloading from https://www.terraform.io/downloads.html

Debug Output

TF_LOG=DEBUG terraform plan 2>&1 | grep databricks | sed -E 's/^.* plugin[^:]+: (.*)$/\1/'
GET /sdlc-devops-us-west-2/hodor/terraform-databricks.tfstate HTTP/1.1
2021-10-15T09:55:21.181-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2119
2021-10-15T09:55:21.188-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:21.242-0500
address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin728954978 network=unix timestamp=2021-10-15T09:55:21.291-0500
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2119
2021/10/15 09:55:21 [DEBUG] adding implicit provider configuration provider["registry.terraform.io/databrickslabs/databricks"], implied first by data.databricks_aws_crossaccount_policy.this
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_instance_profile.instance_role" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_mws_workspaces.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "data.databricks_aws_bucket_policy.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "data.databricks_aws_assume_role_policy.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "data.databricks_aws_crossaccount_policy.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_mws_storage_configurations.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "aws_iam_role_policy.databricks_provided" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/hashicorp/aws"]
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "data.databricks_group.users" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_mws_networks.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_mws_credentials.this" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:21 [DEBUG] ProviderTransformer: "databricks_group_instance_profile.all" (*terraform.NodeValidatableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "var.databricks_host" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_instance_profile.instance_role" references: [aws_iam_role_policy.s3_policy aws_iam_role_policy.instance_profile_permissions databricks_mws_workspaces.this aws_iam_instance_profile.instance_role]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "var.databricks_account_password" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_iam_role.instance_role" references: [var.databricks_workspace_name var.databricks_workspace_name data.aws_iam_policy_document.assume_role_for_ec2]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_mws_storage_configurations.this" references: [aws_s3_bucket.root_storage_bucket var.databricks_workspace_name var.databricks_account_id]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_iam_role.control_plane_role" references: [var.databricks_workspace_name data.databricks_aws_assume_role_policy.this var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "data.databricks_group.users" references: [databricks_mws_workspaces.this]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "var.databricks_account_username" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"].mws" references: [var.databricks_account_username var.databricks_account_password var.databricks_host]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "module.vpc.var.default_security_group_name (expand)" references: [var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "var.databricks_account_id" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "output.databricks_host" references: [databricks_mws_workspaces.this]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_group_instance_profile.all" references: [databricks_mws_workspaces.this data.databricks_group.users databricks_instance_profile.instance_role]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_s3_bucket.root_storage_bucket" references: [var.databricks_workspace_name var.tags var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_mws_credentials.this" references: [aws_iam_role_policy.databricks_provided aws_iam_role.control_plane_role var.databricks_account_id var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "data.databricks_aws_assume_role_policy.this" references: [var.databricks_account_id]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_mws_workspaces.this" references: [var.databricks_workspace_name databricks_mws_credentials.this databricks_mws_networks.this var.databricks_account_id var.databricks_workspace_name var.aws_region databricks_mws_storage_configurations.this]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "data.databricks_aws_bucket_policy.this" references: [aws_s3_bucket.root_storage_bucket]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "databricks_mws_networks.this" references: [module.vpc.output.default_security_group_id (expand) module.vpc.output.private_subnets (expand) module.vpc.output.vpc_id (expand) var.databricks_workspace_name var.databricks_account_id]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"]" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "var.databricks_workspace_name" references: []
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_iam_role_policy.instance_profile_permissions" references: [var.databricks_workspace_name aws_iam_role.instance_role aws_iam_role.control_plane_role]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "module.vpc.var.name (expand)" references: [var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "module.vpc_endpoints.var.endpoints (expand)" references: [module.vpc.output.private_route_table_ids (expand) module.vpc.output.public_route_table_ids (expand) var.databricks_workspace_name module.vpc.output.private_subnets (expand) var.databricks_workspace_name module.vpc.output.private_subnets (expand) var.databricks_workspace_name]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"].created_workspace" references: [databricks_mws_workspaces.this var.databricks_account_password var.databricks_account_username]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_iam_role_policy.databricks_provided" references: [data.databricks_aws_crossaccount_policy.this aws_iam_role.control_plane_role]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "aws_s3_bucket_policy.root_bucket_policy" references: [aws_s3_bucket_public_access_block.root_storage_bucket aws_s3_bucket.root_storage_bucket data.databricks_aws_bucket_policy.this]
2021/10/15 09:55:21 [DEBUG] ReferenceTransformer: "data.databricks_aws_crossaccount_policy.this" references: []
    var.databricks_workspace_name - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
  output.databricks_host - *terraform.NodeApplyableOutput
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
  provider["registry.terraform.io/databrickslabs/databricks"] - *terraform.NodeApplyableProvider
  provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
  provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    var.databricks_account_username - *terraform.NodeRootVariable
    var.databricks_host - *terraform.NodeRootVariable
  var.databricks_account_id - *terraform.NodeRootVariable
  var.databricks_account_password - *terraform.NodeRootVariable
  var.databricks_account_username - *terraform.NodeRootVariable
  var.databricks_host - *terraform.NodeRootVariable
  var.databricks_workspace_name - *terraform.NodeRootVariable
    output.databricks_host - *terraform.NodeApplyableOutput
    provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
    provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    var.databricks_account_id - *terraform.NodeRootVariable
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
    var.databricks_host - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
var.databricks_workspace_name - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
  output.databricks_host - *terraform.NodeApplyableOutput
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
  provider["registry.terraform.io/databrickslabs/databricks"] - *terraform.NodeApplyableProvider
  provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
  provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    var.databricks_account_username - *terraform.NodeRootVariable
    var.databricks_host - *terraform.NodeRootVariable
  var.databricks_account_id - *terraform.NodeRootVariable
  var.databricks_account_password - *terraform.NodeRootVariable
  var.databricks_account_username - *terraform.NodeRootVariable
  var.databricks_host - *terraform.NodeRootVariable
  var.databricks_workspace_name - *terraform.NodeRootVariable
    output.databricks_host - *terraform.NodeApplyableOutput
    provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
    provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    var.databricks_account_id - *terraform.NodeRootVariable
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
    var.databricks_host - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
var.databricks_workspace_name - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
    var.databricks_workspace_name - *terraform.NodeRootVariable
  output.databricks_host - *terraform.NodeApplyableOutput
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
  provider["registry.terraform.io/databrickslabs/databricks"] - *terraform.NodeApplyableProvider
  provider["registry.terraform.io/databrickslabs/databricks"] (close) - *terraform.graphNodeCloseProvider
    data.databricks_aws_assume_role_policy.this - *terraform.NodeValidatableResource
    data.databricks_aws_bucket_policy.this - *terraform.NodeValidatableResource
    data.databricks_aws_crossaccount_policy.this - *terraform.NodeValidatableResource
  provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
  provider["registry.terraform.io/databrickslabs/databricks"].created_workspace (close) - *terraform.graphNodeCloseProvider
    data.databricks_group.users - *terraform.NodeValidatableResource
    databricks_group_instance_profile.all - *terraform.NodeValidatableResource
    databricks_instance_profile.instance_role - *terraform.NodeValidatableResource
    provider["registry.terraform.io/databrickslabs/databricks"].created_workspace - *terraform.NodeApplyableProvider
  provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    var.databricks_account_password - *terraform.NodeRootVariable
    var.databricks_account_username - *terraform.NodeRootVariable
    var.databricks_host - *terraform.NodeRootVariable
  provider["registry.terraform.io/databrickslabs/databricks"].mws (close) - *terraform.graphNodeCloseProvider
    databricks_mws_credentials.this - *terraform.NodeValidatableResource
    databricks_mws_networks.this - *terraform.NodeValidatableResource
    databricks_mws_storage_configurations.this - *terraform.NodeValidatableResource
    databricks_mws_workspaces.this - *terraform.NodeValidatableResource
    provider["registry.terraform.io/databrickslabs/databricks"].mws - *terraform.NodeApplyableProvider
    aws_iam_role_policy.databricks_provided - *terraform.NodeValidatableResource
  var.databricks_account_id - *terraform.NodeRootVariable
  var.databricks_account_password - *terraform.NodeRootVariable
  var.databricks_account_username - *terraform.NodeRootVariable
  var.databricks_host - *terraform.NodeRootVariable
  var.databricks_workspace_name - *terraform.NodeRootVariable
2021-10-15T09:55:21.962-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2121
2021-10-15T09:55:21.967-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:21.990-0500
address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin351539580 network=unix timestamp=2021-10-15T09:55:22.032-0500
2021-10-15T09:55:22.383-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2123
2021-10-15T09:55:22.388-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:22.415-0500
address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin949419686 network=unix timestamp=2021-10-15T09:55:22.456-0500
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2121
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2123
2021-10-15T09:55:22.767-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2124
2021-10-15T09:55:22.773-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:22.796-0500
address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin661008739 network=unix timestamp=2021-10-15T09:55:22.834-0500
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2124
2021/10/15 09:55:22 [DEBUG] adding implicit provider configuration provider["registry.terraform.io/databrickslabs/databricks"], implied first by databricks_mws_networks.this (expand)
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "data.databricks_group.users (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "aws_iam_role_policy.databricks_provided (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/hashicorp/aws"]
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_mws_storage_configurations.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_mws_credentials.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "data.databricks_aws_crossaccount_policy.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "data.databricks_aws_assume_role_policy.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_mws_workspaces.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_group_instance_profile.all (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "data.databricks_aws_bucket_policy.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"]
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_instance_profile.instance_role (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].created_workspace
2021/10/15 09:55:22 [DEBUG] ProviderTransformer: "databricks_mws_networks.this (expand)" (*terraform.nodeExpandPlannableResource) needs provider["registry.terraform.io/databrickslabs/databricks"].mws
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_instance_profile.instance_role (expand)" references: [aws_iam_role_policy.s3_policy (expand) aws_iam_role_policy.instance_profile_permissions (expand) databricks_mws_workspaces.this (expand) aws_iam_instance_profile.instance_role (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "var.databricks_host" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_s3_bucket_policy.root_bucket_policy (expand)" references: [aws_s3_bucket_public_access_block.root_storage_bucket (expand) aws_s3_bucket.root_storage_bucket (expand) data.databricks_aws_bucket_policy.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_iam_role.control_plane_role (expand)" references: [var.databricks_workspace_name var.databricks_workspace_name data.databricks_aws_assume_role_policy.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "module.vpc.var.name (expand)" references: [var.databricks_workspace_name]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "module.vpc_endpoints.var.endpoints (expand)" references: [module.vpc.output.private_route_table_ids (expand) module.vpc.output.public_route_table_ids (expand) var.databricks_workspace_name module.vpc.output.private_subnets (expand) var.databricks_workspace_name module.vpc.output.private_subnets (expand) var.databricks_workspace_name]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "data.databricks_aws_bucket_policy.this (expand)" references: [aws_s3_bucket.root_storage_bucket (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "var.databricks_account_id" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_iam_role_policy.databricks_provided (expand)" references: [aws_iam_role.control_plane_role (expand) data.databricks_aws_crossaccount_policy.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_mws_storage_configurations.this (expand)" references: [var.databricks_workspace_name var.databricks_account_id aws_s3_bucket.root_storage_bucket (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "data.databricks_aws_assume_role_policy.this (expand)" references: [var.databricks_account_id]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_mws_networks.this (expand)" references: [var.databricks_workspace_name var.databricks_account_id module.vpc.output.default_security_group_id (expand) module.vpc.output.private_subnets (expand) module.vpc.output.vpc_id (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "var.databricks_account_username" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "data.databricks_group.users (expand)" references: [databricks_mws_workspaces.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "var.databricks_account_password" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"]" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_iam_role_policy.instance_profile_permissions (expand)" references: [var.databricks_workspace_name aws_iam_role.instance_role (expand) aws_iam_role.control_plane_role (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"].created_workspace" references: [var.databricks_account_password var.databricks_account_username databricks_mws_workspaces.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_mws_credentials.this (expand)" references: [aws_iam_role_policy.databricks_provided (expand) var.databricks_workspace_name aws_iam_role.control_plane_role (expand) var.databricks_account_id]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_s3_bucket.root_storage_bucket (expand)" references: [var.databricks_workspace_name var.tags var.databricks_workspace_name]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_mws_workspaces.this (expand)" references: [var.aws_region databricks_mws_storage_configurations.this (expand) var.databricks_workspace_name databricks_mws_credentials.this (expand) var.databricks_workspace_name databricks_mws_networks.this (expand) var.databricks_account_id]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "var.databricks_workspace_name" references: []
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "output.databricks_host" references: [databricks_mws_workspaces.this (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "module.vpc.var.default_security_group_name (expand)" references: [var.databricks_workspace_name]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "databricks_group_instance_profile.all (expand)" references: [databricks_mws_workspaces.this (expand) data.databricks_group.users (expand) databricks_instance_profile.instance_role (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "aws_iam_role.instance_role (expand)" references: [var.databricks_workspace_name var.databricks_workspace_name data.aws_iam_policy_document.assume_role_for_ec2 (expand)]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "provider[\"registry.terraform.io/databrickslabs/databricks\"].mws" references: [var.databricks_account_password var.databricks_account_username var.databricks_host]
2021/10/15 09:55:22 [DEBUG] ReferenceTransformer: "data.databricks_aws_crossaccount_policy.this (expand)" references: []
2021-10-15T09:55:23.069-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2125
2021-10-15T09:55:23.074-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:23.097-0500
network=unix address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin335890720 timestamp=2021-10-15T09:55:23.138-0500
2021-10-15T09:55:23.257-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2126
2021-10-15T09:55:23.262-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:23.286-0500
address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin150674677 network=unix timestamp=2021-10-15T09:55:23.327-0500
Explicit and implicit attributes:: timestamp=2021-10-15T09:55:23.405-0500
2021/10/15 09:55:23 [DEBUG] ReferenceTransformer: "data.databricks_aws_crossaccount_policy.this" references: []
2021/10/15 09:55:23 [INFO] ReferenceTransformer: reference not found: "var.databricks_account_id"
2021/10/15 09:55:23 [DEBUG] ReferenceTransformer: "data.databricks_aws_assume_role_policy.this" references: []
2021/10/15 09:55:23 [WARN] Provider "registry.terraform.io/databrickslabs/databricks" produced an unexpected new value for data.databricks_aws_assume_role_policy.this.
      - .databricks_account_id: was null, but now cty.StringVal("414351767826")
Explicit and implicit attributes: host, password, username: timestamp=2021-10-15T09:55:23.644-0500
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:24 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
          <Value>hodor/terraform-databricks</Value>
          <Value>databricks</Value>
          <Value>databricks</Value>
          <Value>hodor/terraform-databricks</Value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
          <Value>databricks</Value>
          <Value>hodor/terraform-databricks</Value>
2021/10/15 09:55:26 [DEBUG] ReferenceTransformer: "aws_iam_role_policy.databricks_provided" references: []
2021/10/15 09:55:26 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
aws_iam_role_policy.databricks_provided: Refreshing state... [id=sdlc-devops-us-west-2-20211012222038266500000001:control-plane-access]
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
          <Value>databricks</Value>
          <Value>hodor/terraform-databricks</Value>
2021/10/15 09:55:26 [INFO] ReferenceTransformer: reference not found: "aws_iam_role_policy.databricks_provided"
2021/10/15 09:55:26 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:26 [INFO] ReferenceTransformer: reference not found: "var.databricks_account_id"
2021/10/15 09:55:26 [DEBUG] ReferenceTransformer: "databricks_mws_credentials.this" references: []
databricks_mws_credentials.this: Refreshing state... [id=01622823-d5fe-4643-8573-1560b2618cde/8c2388be-68a2-4cc1-919d-bd0feef66fb9]
Using basic auth for user 'dev-ops@hodor.hodor': timestamp=2021-10-15T09:55:26.549-0500
Using directly configured host+basic_auth authentication: timestamp=2021-10-15T09:55:26.549-0500
GET /api/2.0/accounts/01622823-d5fe-4643-8573-1560b2618cde/credentials/8c2388be-68a2-4cc1-919d-bd0feef66fb9: timestamp=2021-10-15T09:55:26.550-0500
200 OK {
                    <value>hodor/terraform-databricks</value>
aform-databricks</value>
                    <value>databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
2021/10/15 09:55:28 [INFO] ReferenceTransformer: reference not found: "var.databricks_account_id"
2021/10/15 09:55:28 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:28 [DEBUG] ReferenceTransformer: "databricks_mws_networks.this" references: []
databricks_mws_networks.this: Refreshing state... [id=01622823-d5fe-4643-8573-1560b2618cde/834c4471-ada2-43c1-813d-e4acee007ad3]
GET /api/2.0/accounts/01622823-d5fe-4643-8573-1560b2618cde/networks/834c4471-ada2-43c1-813d-e4acee007ad3: timestamp=2021-10-15T09:55:28.583-0500
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
databricks</value>
                    <value>databricks</value>
aform-databricks</value>
                    <value>databricks</value>
databricks</value>
                    <value>databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
aform-databricks</value>
                    <value>databricks</value>
200 OK {
Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2021-10-15T09:55:29.414-0500
Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2021-10-15T09:55:29.414-0500
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
                    <value>databricks</value>
                    <value>hodor/terraform-databricks</value>
<Tagging xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><TagSet><Tag><Key>environment</Key><Value>stage</Value></Tag><Tag><Key>terraform-workspace</Key><Value>sdlc-devops-us-west-2</Value></Tag><Tag><Key>project</Key><Value>databricks</Value></Tag><Tag><Key>env_type</Key><Value>non_prod</Value></Tag><Tag><Key>terraform-path</Key><Value>root</Value></Tag><Tag><Key>Name</Key><Value>sdlc-devops-us-west-2-rootbucket</Value></Tag><Tag><Key>github-repo</Key><Value>hodor/terraform-databricks</Value></Tag></TagSet></Tagging>: timestamp=2021-10-15T09:55:29.968-0500
2021/10/15 09:55:29 [DEBUG] ReferenceTransformer: "data.databricks_aws_bucket_policy.this" references: []
2021/10/15 09:55:29 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:29 [INFO] ReferenceTransformer: reference not found: "var.databricks_account_id"
2021/10/15 09:55:29 [DEBUG] ReferenceTransformer: "databricks_mws_storage_configurations.this" references: []
databricks_mws_storage_configurations.this: Refreshing state... [id=01622823-d5fe-4643-8573-1560b2618cde/4342f42b-f5f3-4f7b-be8f-be21445337a9]
GET /api/2.0/accounts/01622823-d5fe-4643-8573-1560b2618cde/storage-configurations/4342f42b-f5f3-4f7b-be8f-be21445337a9: timestamp=2021-10-15T09:55:29.984-0500
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2125
200 OK {
2021/10/15 09:55:30 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:30 [INFO] ReferenceTransformer: reference not found: "var.databricks_workspace_name"
2021/10/15 09:55:30 [INFO] ReferenceTransformer: reference not found: "var.databricks_account_id"
2021/10/15 09:55:30 [DEBUG] ReferenceTransformer: "databricks_mws_workspaces.this" references: []
databricks_mws_workspaces.this: Refreshing state... [id=01622823-d5fe-4643-8573-1560b2618cde/1233332061011873]
GET /api/2.0/accounts/01622823-d5fe-4643-8573-1560b2618cde/workspaces/1233332061011873: timestamp=2021-10-15T09:55:30.105-0500
200 OK {
Waiting for state to become: [success]: timestamp=2021-10-15T09:55:30.227-0500
GET /api/2.0/accounts/01622823-d5fe-4643-8573-1560b2618cde/workspaces/1233332061011873: timestamp=2021-10-15T09:55:30.228-0500
200 OK {
Workspace is now running: timestamp=2021-10-15T09:55:30.351-0500
Workspace https://hodordata-sdlc-devops-us-west-2.cloud.databricks.com is ready to use: timestamp=2021-10-15T09:55:30.498-0500
2021-10-15T09:55:30.570-0500 [DEBUG] plugin: starting plugin: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 args=[.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9]
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2128
2021-10-15T09:55:30.577-0500 [DEBUG] plugin: waiting for RPC address: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9
Databricks Terraform Provider (experimental)

Version 0.3.9

https://registry.terraform.io/providers/databrickslabs/databricks/latest/docs

configuring server automatic mTLS: timestamp=2021-10-15T09:55:30.605-0500
network=unix address=/var/folders/1m/xz07j87101qb7hz6b53zz1n40000gp/T/plugin068215895 timestamp=2021-10-15T09:55:30.648-0500
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2126
Explicit and implicit attributes: host, password, username: timestamp=2021-10-15T09:55:30.735-0500
2021/10/15 09:55:30 [INFO] ReferenceTransformer: reference not found: "databricks_mws_workspaces.this"
2021/10/15 09:55:30 [DEBUG] ReferenceTransformer: "databricks_instance_profile.instance_role" references: []
2021/10/15 09:55:30 [INFO] ReferenceTransformer: reference not found: "databricks_mws_workspaces.this"
2021/10/15 09:55:30 [DEBUG] ReferenceTransformer: "data.databricks_group.users" references: []
databricks_instance_profile.instance_role: Refreshing state... [id=arn:aws:iam::694017378957:instance-profile/sdlc-devops-us-west-2-20211012221409208600000001]
Using basic auth for user 'dev-ops@hodor.hodor': timestamp=2021-10-15T09:55:30.738-0500
Using directly configured host+basic_auth authentication: timestamp=2021-10-15T09:55:30.738-0500
GET /api/2.0/instance-profiles/list: timestamp=2021-10-15T09:55:30.738-0500
200 OK {
2021/10/15 09:55:31 [DEBUG] Resource instance state not found for node "databricks_group_instance_profile.all", instance databricks_group_instance_profile.all
2021/10/15 09:55:31 [INFO] ReferenceTransformer: reference not found: "databricks_mws_workspaces.this"
2021/10/15 09:55:31 [DEBUG] ReferenceTransformer: "databricks_group_instance_profile.all" references: []
2021/10/15 09:55:31 [DEBUG] refresh: databricks_group_instance_profile.all: no state, so not refreshing
path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.9/darwin_amd64/terraform-provider-databricks_v0.3.9 pid=2128
  # data.databricks_aws_bucket_policy.this will be read during apply
 <= data "databricks_aws_bucket_policy" "this"  {
      - databricks_account_id = "414351767826" -> null
  # data.databricks_group.users will be read during apply
 <= data "databricks_group" "users"  {
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
  # databricks_group_instance_profile.all will be created
  + resource "databricks_group_instance_profile" "all" {
  # databricks_instance_profile.instance_role will be updated in-place
  ~ resource "databricks_instance_profile" "instance_role" {
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"
          + "github-repo"    = "hodor/terraform-databricks"
          + "project"        = "databricks"

Important Factoids

This relates strongly to #857 and #762

BenMcClainCarpe commented 3 years ago

FYI @ricardogaspar2

nfx commented 3 years ago

@BenMcClainCarpe @ricardogaspar2

issue will be fixed in v0.3.10 - i really wonder how current integration test suite didn't catch this.

If anyone is willing to fix that earlier - it's DiffSuppressFunc on skipvalidation field in StructToSchema callback.

as a workaround until then - 

lifecycle {
    ignore_changes = [skip_validation]
  }
nfx commented 3 years ago

And is it really Error: doesn't support update? It should have prompted to replace the resource.

BenMcClainCarpe commented 3 years ago

And is it really Error: doesn't support update? It should have prompted to replace the resource.

Yea what you see up there was just a copy and paste from the run. It's not a huge thing, but thanks for looking into it.

nfx commented 3 years ago

@BenMcClainCarpe you should not be adding skip_validation = true in the first place :)

BenMcClainCarpe commented 3 years ago

We have to for the same tagging reasons as @tylangesmith in #762

nfx commented 3 years ago

ah, okay, then it makes sense :)

nfx commented 3 years ago

@BenMcClainCarpe Did the workaround help?

BenMcClainCarpe commented 3 years ago

Yes it did. It recreates the instance profile each time an apply is run. I'm no databricks expert here though. @ricardogaspar2 could say whether that's a problem for currently running clusters/whatnot, when he gets a chance. As far as Terraform is concerned though, it works fine.

New code:

resource "databricks_instance_profile" "instance_role" {
  provider = databricks.created_workspace
  depends_on = [
    aws_iam_role_policy.s3_policy,
    aws_iam_role_policy.instance_profile_permissions,
    databricks_mws_workspaces.this
  ]
  instance_profile_arn = aws_iam_instance_profile.instance_role.arn
  skip_validation = true
  lifecycle {  # See the note about this resource in the README.md
    ignore_changes = [skip_validation]
  }
}

Output:

  # databricks_group_instance_profile.all must be replaced
-/+ resource "databricks_group_instance_profile" "all" {
      ~ group_id            = "676678810592129" -> (known after apply) # forces replacement
      ~ id                  = "676678810592129|arn:aws:iam::694017378957:instance-profile/sdlc-devops-us-west-2-20211012221409208600000001" -> (known after apply)
        # (1 unchanged attribute hidden)
    }
nfx commented 3 years ago

Could you check if 1.x is not having this issue, just out of curiosity.

Just in case, provider core team is only testing with TF version adopted by 50% of users and currently it's v1.0

BenMcClainCarpe commented 3 years ago

Hey nfx, I see the same behavior on terraform 1.0.9.
Without the lifecycle block, it fails because it can't update.
With it, it recreates the databricks_instance_profile each time.