databrickslabs / blueprint

Baseline for Databricks Labs projects written in Python
https://pypi.org/project/databricks-labs-blueprint/
Other
19 stars 8 forks source link

Fixed bug for double-uploading of unreleased wheels in air-gapped setups #103

Closed nfx closed 5 months ago

nfx commented 5 months ago

With the changes from #99, we were not hitting if wheel.name == self._local_wheel.name condition for unreleased wheels, resulting in undefined behavior:

product_info = ProductInfo.from_class(WheelsV2)
with WheelsV2(new_installation, product_info) as whl:
    whl.upload_wheel_dependencies(["databricks"])
    installation_files = new_installation.files()
    # only Databricks SDK has to be uploaded
    assert len(installation_files) == 1
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (50b5474) to head (ab61bd4).

Files Patch % Lines
src/databricks/labs/blueprint/wheels.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== + Coverage 78.72% 78.78% +0.05% ========================================== Files 14 14 Lines 1495 1499 +4 Branches 269 269 ========================================== + Hits 1177 1181 +4 Misses 230 230 Partials 88 88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

✅ 12/12 passed, 2 skipped, 24s total

Running from acceptance #130