databrickslabs / blueprint

Baseline for Databricks Labs projects written in Python
https://pypi.org/project/databricks-labs-blueprint/
Other
19 stars 8 forks source link

Apply type casting & remove empty kwarg for Command #108

Closed nkvuong closed 5 months ago

nkvuong commented 5 months ago

Currently, all kwargs are passed into App.command as str. Empty kwarg is passed as empty string.

In this PR, we remove any empty kwarg, and apply casting based on the kwarg annotation for primitive types

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.05%. Comparing base (2b75d24) to head (cc89c55). Report is 3 commits behind head on main.

:exclamation: Current head cc89c55 differs from pull request most recent head 73c601f

Please upload reports for the commit 73c601f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ========================================== + Coverage 78.78% 79.05% +0.27% ========================================== Files 14 14 Lines 1499 1509 +10 Branches 269 272 +3 ========================================== + Hits 1181 1193 +12 + Misses 230 229 -1 + Partials 88 87 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.