Closed nfx closed 9 months ago
Attention: 38 lines
in your changes are missing coverage. Please review.
Comparison is base (
2f8d21a
) 77.95% compared to head (e2ecd49
) 77.43%.
Files | Patch % | Lines |
---|---|---|
src/databricks/labs/blueprint/installation.py | 57.64% | 34 Missing and 2 partials :warning: |
src/databricks/labs/blueprint/installer.py | 83.33% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request introduces several changes to the
Installation
framework in order to align it with the UCX project. The main changes are the addition of new methods to theInstallation
class, as well as modifications to the tests intest_installer.py
.In the
Installation
class, several new methods have been added:load_local
,username
,remove
,workspace_link
,workspace_markdown_link
, and_host
. Theload_local
method loads an object of a specific type from a local file, whileusername
returns the username associated with the installation. Theremove
method removes the installation folder from the workspace, andworkspace_link
andworkspace_markdown_link
return links to files in the workspace. The_host
method returns the host URL for the workspace.In the
test_installer.py
file, the tests for theInstallState
class have been updated to include a new test for thefrom_installation
method, which creates anInstallState
object from an existingInstallation
object. Additionally, thetest_state_corrupt
test has been added to test the behavior of theInstallState
class when the installation is not found.Overall, this pull request aims to improve the functionality and robustness of the
Installation
framework by adding new methods and updating the tests.Relevant PRs: