databrickslabs / brickster

R Toolkit for Databricks
https://databrickslabs.github.io/brickster/
Apache License 2.0
39 stars 6 forks source link

Connection pane improvements #29

Closed skodman closed 5 months ago

skodman commented 1 year ago

Created brixter.env environment to hold the data and reduce the number of API calls (if possible). I wanted to separate clusters by their purpose so I've added skodman_test element to the connections tree list with two leafs under neath: Personal and Job (left Pools from the list as we are not using those so i can't test, should probably be be added). Have a look at the brixter.env environment, get_clusters_2 and filter_clusters functions below. Was wondering if this is something you might want to consider and if so i can cleanup the code. I've also made some changes to fix the name of the workspace in the Connections tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #29 (a7c1217) into main (c111be3) will decrease coverage by 0.16%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   11.74%   11.59%   -0.16%     
==========================================
  Files          22       22              
  Lines        2682     2717      +35     
==========================================
  Hits          315      315              
- Misses       2367     2402      +35     
Impacted Files Coverage Δ
R/connection-pane.R 0.00% <0.00%> (ø)
R/unity-catalog.R 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

zacdav-db commented 5 months ago

Will close this for now and re-visit connection pane ideas once I've implemented some changes to it's core behaviour that are required.