databrickslabs / dbignite

Other
22 stars 11 forks source link

Refactoring dbinterop to dbignite #3

Closed kermany closed 1 year ago

kermany commented 1 year ago

This PR is to change dbignite (dbiterop) design and add tests.

TODO: Add doc strings

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | 258207815637a720c4802f153e50ec2c95de40af | dbignite-demo.py | [View secret](https://github.com/databrickslabs/dbignite/commit/258207815637a720c4802f153e50ec2c95de40af#diff-939c19cf28f541bfbfed2696a76886e6L29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | ed575ca451850f6dfd6bf2449046e7e215a6d622 | notebooks/dbignite-demo-feature-store.py | [View secret](https://github.com/databrickslabs/dbignite/commit/ed575ca451850f6dfd6bf2449046e7e215a6d622#diff-4067e9033a7087a1ad73e136f62c3ccbL29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | d3d7cba7517e6cf85a5aec659e6a9ef6aa7f8adc | notebooks/dbignite-demo-feature-store.py | [View secret](https://github.com/databrickslabs/dbignite/commit/d3d7cba7517e6cf85a5aec659e6a9ef6aa7f8adc#diff-4067e9033a7087a1ad73e136f62c3ccbR29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | d3d7cba7517e6cf85a5aec659e6a9ef6aa7f8adc | notebooks/dbignite-demo.py | [View secret](https://github.com/databrickslabs/dbignite/commit/d3d7cba7517e6cf85a5aec659e6a9ef6aa7f8adc#diff-ff8da59b36ee618d80ec70ccc5a85e85R29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | b67ca3126fadc470f9a22dd450dd59cdedc828ef | notebooks/dbignite-demo-feature-store.py | [View secret](https://github.com/databrickslabs/dbignite/commit/b67ca3126fadc470f9a22dd450dd59cdedc828ef#diff-4067e9033a7087a1ad73e136f62c3ccbR29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | 2ff0b73640271520e8b45635fcf07c6124483b38 | notebooks/dbignite-demo.py | [View secret](https://github.com/databrickslabs/dbignite/commit/2ff0b73640271520e8b45635fcf07c6124483b38#diff-ff8da59b36ee618d80ec70ccc5a85e85R29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | 182b90733ad41e68e4741aa8200b36cc7c5f149d | notebooks/dbignite-demo-feature-store.py | [View secret](https://github.com/databrickslabs/dbignite/commit/182b90733ad41e68e4741aa8200b36cc7c5f149d#diff-4067e9033a7087a1ad73e136f62c3ccbR29) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | GitHub Access Token | 182b90733ad41e68e4741aa8200b36cc7c5f149d | notebooks/dbignite-demo.py | [View secret](https://github.com/databrickslabs/dbignite/commit/182b90733ad41e68e4741aa8200b36cc7c5f149d#diff-ff8da59b36ee618d80ec70ccc5a85e85R29) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/github_personal_access_token_v2#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7882d29). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   91.78%           
=========================================
  Files             ?        4           
  Lines             ?      219           
  Branches          ?        0           
=========================================
  Hits              ?      201           
  Misses            ?       18           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.