Develop - PR for comparison only

ronanstokes-db commented 1 year ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers. If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to dbldatagen? Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to tutorials, tests or examples
[ ] Non code change (readme, images or other non-code assets)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Submission does not reduce code coverage numbers
[ ] Submission does not increase alerts or messages from LGTM

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 1 year ago

Codecov Report

Merging #139 (76e7581) into master (981a5a4) will increase coverage by 3.72%. The diff coverage is 96.71%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   86.90%   90.63%   +3.72%     
==========================================
  Files          21       22       +1     
  Lines        2161     2487     +326     
  Branches      367      406      +39     
==========================================
+ Hits         1878     2254     +376     
+ Misses        183      150      -33     
+ Partials      100       83      -17

Impacted Files	Coverage Δ
dbldatagen/__init__.py	`90.90% <ø> (ø)`
dbldatagen/text_generator_plugins.py	`73.98% <50.00%> (ø)`
dbldatagen/utils.py	`97.77% <90.47%> (+7.34%)`	:arrow_up:
dbldatagen/text_generators.py	`96.58% <96.51%> (+16.81%)`	:arrow_up:
dbldatagen/data_generator.py	`84.69% <98.33%> (+1.46%)`	:arrow_up:
dbldatagen/schema_parser.py	`97.68% <98.57%> (+4.35%)`	:arrow_up:
dbldatagen/_version.py	`100.00% <100.00%> (ø)`
dbldatagen/column_generation_spec.py	`88.02% <100.00%> (+0.69%)`	:arrow_up:
dbldatagen/column_spec_options.py	`96.96% <100.00%> (ø)`
dbldatagen/datagen_constants.py	`100.00% <100.00%> (ø)`
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts and fixes 8 when merging bbffaef78b73555fcfd0cda191ee58528dd4c137 into 981a5a4b07b0ee981c5b77ee908c855c47f84bb2 - view on LGTM.com

new alerts:

2 for Syntax error

fixed alerts:

7 for Unused local variable
1 for Unreachable code

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts and fixes 6 when merging 5042cc3323e34cf5a6d076d8dc070d18ea85ff67 into 981a5a4b07b0ee981c5b77ee908c855c47f84bb2 - view on LGTM.com

new alerts:

1 for Unused import
1 for Syntax error

fixed alerts:

5 for Unused local variable
1 for Unreachable code

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

databrickslabs / dbldatagen