Closed ronanstokes-db closed 1 year ago
Merging #148 (54ff7bd) into master (542809f) will increase coverage by
0.03%
. The diff coverage is100.00%
.:exclamation: Current head 54ff7bd differs from pull request most recent head bc081d8. Consider uploading reports for the commit bc081d8 to get more accurate results
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 90.63% 90.66% +0.03%
==========================================
Files 22 22
Lines 2487 2495 +8
Branches 406 408 +2
==========================================
+ Hits 2254 2262 +8
Misses 150 150
Partials 83 83
Impacted Files | Coverage Δ | |
---|---|---|
dbldatagen/column_spec_options.py | 96.96% <ø> (ø) |
|
dbldatagen/column_generation_spec.py | 88.02% <100.00%> (ø) |
|
dbldatagen/data_generator.py | 84.75% <100.00%> (+0.05%) |
:arrow_up: |
dbldatagen/utils.py | 97.87% <100.00%> (+0.09%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
already merged
Proposed changes
Fixes for array valued column issues
Types of changes
What types of changes does your code introduce to dbldatagen? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...