Closed ronanstokes-db closed 1 year ago
Merging #150 (1af73a1) into master (41f41bb) will increase coverage by
0.51%
. The diff coverage is98.33%
.
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 89.64% 90.15% +0.51%
==========================================
Files 22 22
Lines 2347 2439 +92
Branches 377 396 +19
==========================================
+ Hits 2104 2199 +95
+ Misses 159 157 -2
+ Partials 84 83 -1
Impacted Files | Coverage Δ | |
---|---|---|
dbldatagen/data_generator.py | 84.03% <ø> (ø) |
|
dbldatagen/schema_parser.py | 97.26% <98.23%> (+3.92%) |
:arrow_up: |
dbldatagen/column_generation_spec.py | 88.02% <100.00%> (+0.69%) |
:arrow_up: |
dbldatagen/data_analyzer.py | 84.21% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Proposed changes
Add support for use of complex columns such as array, map and struct type columns.
Changes include:
expr
attribute is populatedTypes of changes
What types of changes does your code introduce to dbldatagen? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...