Closed ronanstokes-db closed 1 year ago
Merging #166 (5e46f9a) into master (431d865) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 90.33% 90.34%
=======================================
Files 22 22
Lines 2515 2516 +1
Branches 416 417 +1
=======================================
+ Hits 2272 2273 +1
Misses 158 158
Partials 85 85
Impacted Files | Coverage Δ | |
---|---|---|
dbldatagen/schema_parser.py | 97.68% <100.00%> (+0.01%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Proposed changes
Fix parsing and cleansing of quoted identifiers
Types of changes
What types of changes does your code introduce to dbldatagen? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...