Closed ronanstokes-db closed 1 year ago
Merging #168 (b725db3) into master (ef04c7b) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 22 22
Lines 2516 2516
Branches 417 417
=======================================
Hits 2273 2273
Misses 158 158
Partials 85 85
Impacted Files | Coverage Δ | |
---|---|---|
dbldatagen/_version.py | 100.00% <100.00%> (ø) |
|
dbldatagen/schema_parser.py | 97.68% <100.00%> (ø) |
... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Proposed changes
Older LTS versions of Databricks runtime use PyParsing 2.4.7 which has different method naming conventions to 3.0.0 onwards
Types of changes
Code will use older form of names for maximum compatibility with Databricks 10.4 LTS. Old names are still supported in later versions of PyParsing
What types of changes does your code introduce to dbldatagen? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...