Feature text generation extensions

ronanstokes-db commented 1 year ago

Proposed changes

Extend text generation with enhancements:

ability to specify custom punctuation for ILText based generation
ability to generate custom identifiers

Types of changes

What types of changes does your code introduce to dbldatagen? Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to tutorials, tests or examples
[ ] Non code change (readme, images or other non-code assets)
[x] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules
[ ] Submission does not reduce code coverage numbers
[ ] Submission does not increase alerts or messages from prospector / lint

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 1 year ago

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (1c8b340) 92.19% compared to head (6e41061) 91.59%. Report is 3 commits behind head on master.

Files	Patch %	Lines
dbldatagen/text_generatestring.py	65.33%	23 Missing and 3 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #214 +/- ## ========================================== - Coverage 92.19% 91.59% -0.61% ========================================== Files 23 24 +1 Lines 2754 2842 +88 Branches 471 487 +16 ========================================== + Hits 2539 2603 +64 - Misses 128 151 +23 - Partials 87 88 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CLAassistant commented 1 year ago

All committers have signed the CLA.

databrickslabs / dbldatagen