Changes and bug fixes to support shared clusters in DBR 14.2

ronanstokes-db commented 7 months ago

Proposed changes

When using a shared cluster with UC shared mode in DBR 14.2, referencing the sparkContext produces an attribute error. To fix this, if an error is thrown when accessing the sparkContext, we use a default parallelism of 200 unless an alternative value was explicitly specified.

This PR also uses the Spark SQL function element_at rather than direct array indexing due to incompatibilities with some spark versions.

Types of changes

What types of changes does your code introduce to dbldatagen? Put an x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Change to tutorials, tests or examples
[ ] Non code change (readme, images or other non-code assets)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
[x] Submission does not reduce code coverage numbers
[x] Submission does not increase alerts or messages from prospector / lint

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6987b2) 92.19% compared to head (22925fd) 92.22%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #248 +/- ## ========================================== + Coverage 92.19% 92.22% +0.02% ========================================== Files 23 23 Lines 2754 2764 +10 Branches 471 472 +1 ========================================== + Hits 2539 2549 +10 Misses 128 128 Partials 87 87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GeekSheikh commented 4 months ago

It's working for me. We're testing it a little deeper but looks good. Please don't forget to bump the version.

databrickslabs / dbldatagen