Open ronanstokes-db opened 4 months ago
Attention: Patch coverage is 45.56962%
with 43 lines
in your changes are missing coverage. Please review.
Project coverage is 90.85%. Comparing base (
02d529e
) to head (1d03614
). Report is 1 commits behind head on master.:exclamation: Current head 1d03614 differs from pull request most recent head 1a1ea31
Please upload reports for the commit 1a1ea31 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
dbldatagen/data_generator.py | 60.00% | 22 Missing and 2 partials :warning: |
dbldatagen/enhanced_event_time.py | 0.00% | 19 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers. If it fixes a bug or resolves a feature request, please provide a link to that issue.
Types of changes
What types of changes does your code introduce to dbldatagen? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...