databrickslabs / dlt-meta

Metadata driven Databricks Delta Live Tables framework for bronze/silver pipelines
https://databrickslabs.github.io/dlt-meta/
Other
148 stars 66 forks source link

Feature/pp apply changes support #2

Closed ravi-databricks closed 1 year ago

ravi-databricks commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #2 (e90c329) into main (0c85fd3) will increase coverage by 4.70%. The diff coverage is 83.54%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   80.17%   84.87%   +4.70%     
==========================================
  Files           7        7              
  Lines         691      734      +43     
  Branches      116      126      +10     
==========================================
+ Hits          554      623      +69     
+ Misses         95       61      -34     
- Partials       42       50       +8     
Flag Coverage Δ
unittests 84.87% <83.54%> (+4.70%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dataflow_pipeline.py 68.00% <72.00%> (+12.51%) :arrow_up:
src/onboard_dataflowspec.py 87.89% <86.11%> (+1.02%) :arrow_up:
src/pipeline_readers.py 91.89% <90.90%> (+14.96%) :arrow_up:
src/dataflow_spec.py 92.20% <100.00%> (+0.15%) :arrow_up:
ganeshchand commented 1 year ago

Since it's a lab project now and the repo is public, we should accept the the contribution from the community. We should update the contributing guide. It still says - "At present, external contributions are not accepted"

ganeshchand commented 1 year ago

Ran unit tests, integration tests and review the docs w/ Ravi. LGTM.