Open rtdtwo opened 5 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
2a93dd9
) 90.28% compared to head (f4fbd2b
) 89.95%.
Files | Patch % | Lines |
---|---|---|
src/onboard_dataflowspec.py | 40.00% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rtdtwo, Needs to add unit tests for added new lines as per above code coverage report.
Issue
The FAQs describes that any data source can be used for silver tables. However, the code always tries to find the bronze database from the onboarding rows, and there's no explicit mention of a source database other than a bronze database.
Fix
Change the code to accomplish the following:
bronze_database_{env}
if the field is found in onboarding rows.source_details
.