search

databrickslabs / lsql

Lightweight SQL execution wrapper only on top of Databricks SDK
https://pypi.org/project/databricks-labs-lsql/
Other
8 stars 3 forks source link

[TECH DEBT] Dashboards class public methods have to work only with DashboardMetadata instances #212

Closed JCZuurmond closed 2 months ago

JCZuurmond commented 2 months ago

Dashboards class public methods have to work only with DashboardMetadata instances. we shouldn't leak any objects of lakeview or sdk in that class' public methods (edited)

JCZuurmond commented 2 months ago

Related to this to having a good signature for Dashboards class public method. Should the deploy_dashboard return the dashboard_id instead of the SDKDashboard:

    def deploy_dashboard(
        self,
        lakeview_dashboard: Dashboard,
        *,
        parent_path: str | None = None,
        dashboard_id: str | None = None,
        warehouse_id: str | None = None,
    ) -> SDKDashboard: