Closed JCZuurmond closed 1 month ago
Related to this to having a good signature for Dashboards class public method. Should deploy_dashboard expect DashboardMetadata as parameter and return the dashboard_id instead of the SDKDashboard?
Dashboards
deploy_dashboard
DashboardMetadata
dashboard_id
SDKDashboard
def deploy_dashboard( self, metadata: DashboardMetadata, *, parent_path: str | None = None, dashboard_id: str | None = None, warehouse_id: str | None = None, ) -> str:
Originally posted by @JCZuurmond in https://github.com/databrickslabs/lsql/issues/212#issuecomment-2222607271
Related to this to having a good signature for
Dashboards
class public method. Shoulddeploy_dashboard
expectDashboardMetadata
as parameter and return thedashboard_id
instead of theSDKDashboard
?Originally posted by @JCZuurmond in https://github.com/databrickslabs/lsql/issues/212#issuecomment-2222607271