databrickslabs / lsql

Lightweight SQL execution wrapper only on top of Databricks SDK
https://pypi.org/project/databricks-labs-lsql/
Other
8 stars 3 forks source link

[TECH DEBT] Deploy dashboard signature #220

Closed JCZuurmond closed 1 month ago

JCZuurmond commented 2 months ago

Related to this to having a good signature for Dashboards class public method. Should deploy_dashboard expect DashboardMetadata as parameter and return the dashboard_id instead of the SDKDashboard?

    def deploy_dashboard(
        self,
        metadata: DashboardMetadata,
        *,
        parent_path: str | None = None,
        dashboard_id: str | None = None,
        warehouse_id: str | None = None,
    ) -> str:

Originally posted by @JCZuurmond in https://github.com/databrickslabs/lsql/issues/212#issuecomment-2222607271