search

databrickslabs / lsql

Lightweight SQL execution wrapper only on top of Databricks SDK
https://pypi.org/project/databricks-labs-lsql/
Other
8 stars 3 forks source link

Remove deploy_dashboard method #240

Closed JCZuurmond closed 1 month ago

JCZuurmond commented 1 month ago

Resolves #232

github-actions[bot] commented 1 month ago

This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details.

Running from downstreams #344

JCZuurmond commented 1 month ago

Backwards compatibility is resolved in: https://github.com/databrickslabs/ucx/pull/2246

github-actions[bot] commented 1 month ago

❌ 34/35 passed, 4 flaky, 1 failed, 2 skipped, 45m11s total

❌ test_dashboards_creates_dashboard_with_replace_database: databricks.sdk.errors.platform.BadRequest: [INSUFFICIENT_PERMISSIONS] Insufficient privileges: (1.778s) ``` databricks.sdk.errors.platform.BadRequest: [INSUFFICIENT_PERMISSIONS] Insufficient privileges: User does not have permission CREATE on CATALOG. SQLSTATE: 42501 14:26 DEBUG [databricks.sdk] Loaded from environment 14:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service 14:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication [gw4] linux -- Python 3.10.14 /home/runner/work/lsql/lsql/.venv/bin/python 14:26 DEBUG [databricks.sdk] Loaded from environment 14:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service 14:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication 14:26 DEBUG [databricks.sdk] POST /api/2.0/lakeview/dashboards > { > "display_name": "created_by_lsql_Ie0aSMwshgienqQH" > } < 200 OK < { < "create_time": "2024-07-25T14:26:36.360Z", < "dashboard_id": "01ef4a91e6231f50a6edaf8735b2ee14", < "display_name": "created_by_lsql_Ie0aSMwshgienqQH", < "etag": "-1947816303", < "lifecycle_state": "ACTIVE", < "parent_path": "/Users/4106dc97-a963-48f0-a079-a578238959a6", < "path": "/Users/4106dc97-a963-48f0-a079-a578238959a6/created_by_lsql_Ie0aSMwshgienqQH.lvdash.json", < "serialized_dashboard": "{\"pages\":[{\"name\":\"63340854\",\"displayName\":\"New Page\"}]}", < "update_time": "2024-07-25T14:26:36.593Z" < } 14:26 DEBUG [databricks.labs.lsql.backends] [api][execute] CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515) 14:26 DEBUG [databricks.labs.lsql.core] Executing SQL statement: CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515) 14:26 DEBUG [databricks.sdk] POST /api/2.0/sql/statements/ > { > "format": "JSON_ARRAY", > "statement": "CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515)", > "warehouse_id": "TEST_DEFAULT_WAREHOUSE_ID" > } < 200 OK < { < "statement_id": "01ef4a91-e67b-1e7a-89fd-82aaf892c876", < "status": { < "error": { < "error_code": "BAD_REQUEST", < "message": "[INSUFFICIENT_PERMISSIONS] Insufficient privileges:\nUser does not have permission CREATE on CATA... (20 more bytes)" < }, < "state": "FAILED" < } < } 14:26 DEBUG [databricks.sdk] Loaded from environment 14:26 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred 14:26 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service 14:26 INFO [databricks.sdk] Using Databricks Metadata Service authentication 14:26 DEBUG [databricks.sdk] POST /api/2.0/lakeview/dashboards > { > "display_name": "created_by_lsql_Ie0aSMwshgienqQH" > } < 200 OK < { < "create_time": "2024-07-25T14:26:36.360Z", < "dashboard_id": "01ef4a91e6231f50a6edaf8735b2ee14", < "display_name": "created_by_lsql_Ie0aSMwshgienqQH", < "etag": "-1947816303", < "lifecycle_state": "ACTIVE", < "parent_path": "/Users/4106dc97-a963-48f0-a079-a578238959a6", < "path": "/Users/4106dc97-a963-48f0-a079-a578238959a6/created_by_lsql_Ie0aSMwshgienqQH.lvdash.json", < "serialized_dashboard": "{\"pages\":[{\"name\":\"63340854\",\"displayName\":\"New Page\"}]}", < "update_time": "2024-07-25T14:26:36.593Z" < } 14:26 DEBUG [databricks.labs.lsql.backends] [api][execute] CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515) 14:26 DEBUG [databricks.labs.lsql.core] Executing SQL statement: CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515) 14:26 DEBUG [databricks.sdk] POST /api/2.0/sql/statements/ > { > "format": "JSON_ARRAY", > "statement": "CREATE SCHEMA hive_metastore.lsql_siziu WITH DBPROPERTIES (RemoveAfter=2024072515)", > "warehouse_id": "TEST_DEFAULT_WAREHOUSE_ID" > } < 200 OK < { < "statement_id": "01ef4a91-e67b-1e7a-89fd-82aaf892c876", < "status": { < "error": { < "error_code": "BAD_REQUEST", < "message": "[INSUFFICIENT_PERMISSIONS] Insufficient privileges:\nUser does not have permission CREATE on CATA... (20 more bytes)" < }, < "state": "FAILED" < } < } 14:26 DEBUG [databricks.sdk] DELETE /api/2.0/lakeview/dashboards/01ef4a91e6231f50a6edaf8735b2ee14 < 200 OK < {} [gw4] linux -- Python 3.10.14 /home/runner/work/lsql/lsql/.venv/bin/python ```

Flaky tests:

Running from acceptance #341