databrickslabs / migrate

Old scripts for one-off ST-to-E2 migrations. Use "terraform exporter" linked in the readme.
Other
186 stars 128 forks source link

Updated error message text when notebook size exceeds 10485760 bytes #292

Open lcirvin opened 1 year ago

lcirvin commented 1 year ago

When attempting to download a notebook greater than 10485760 bytes in size, the API previously returned an error formatted as follows:

{"error_code": "BAD_REQUEST", "message": "Size exceeds 10485760 bytes", "http_status_code": 400, "path": "/Users/xxx@xxx.com/xxx"}

There appears to have been an update, such that the error is now formatted more along the lines of:

{"error_code": "BAD_REQUEST", "message": "Notebook size exceeded limit: *(some file size)* > 10485760", "http_status_code": 400, "path": "/Users/xxx@xxx.com/xxx"}

This PR updates WorkspaceClient.py to account for the update, to restore functionality provided by the --skip-large-nb flag

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.