Improve `make_group`/`make_acc_group` fixture consistency

asnare commented 1 month ago

Changes

This PR implements some fixture improvements that were originally implemented downstream:

When creating an account or workspace group, we now require the group to be visible via two subsequent .get() and .list() calls. This double-check approach mitigates (but doesn't completely eliminate) problems with consistency of the APIs for working with groups.
The wait_for_provisioning argument to the make_group and make_acc_group has now been removed: we always wait. (For compatibility the argument is still accepted but will trigger a deprecation warning.)

An incidental change is the internal unit-test plumbing can now be provided with mock fixtures specific to the test; this is needed to ensure the double-check implementation can be tested from the unit tests.

Linked issues

Supersedes databrickslabs/ucx#2634.

Tests

added/updated unit tests
existing integration tests

github-actions[bot] commented 1 month ago

This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details.

_{Running from downstreams #46}

github-actions[bot] commented 1 month ago

✅ 35/35 passed, 3 skipped, 2m30s total

_{Running from acceptance #87}

asnare commented 1 month ago

This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details.

Running from downstreams #32

I don't fully understand why this check is failing…?

databrickslabs / pytester