search

databrickslabs / remorph

Cross-compiler and Data Reconciler into Databricks Lakehouse
Other
47 stars 30 forks source link

Transpile snow flake select statement #1203

Open ericvergnaud opened 1 week ago

ericvergnaud commented 1 week ago

borrows technical idea from #1208, but applies it to a new field, thus avoiding any backwards compatibility issue.

Adds a test for checking transpilation of SnowFlake select statement, and fixes issues

Requires https://github.com/databrickslabs/remorph/pull/1201

Progresses https://github.com/databrickslabs/remorph/issues/869

Supersedes #1193

github-actions[bot] commented 1 week ago

Coverage tests results

448 tests  ±0   414 ✅ ±0   4s ⏱️ ±0s   6 suites ±0    34 💤 ±0    6 files   ±0     0 ❌ ±0 

Results for commit 53de7dc0. ± Comparison against base commit 444edfef.

ericvergnaud commented 1 week ago

I think we have started running before we know the correct direction. As per previous comments, we need to design this as it is potentially a big change.

Indeed but feasability can only be proven by feasing...

Now we know what can be done, and we have evidence of which problems are introduced