databrickslabs / remorph

Cross-compiler and Data Reconciler into Databricks Lakehouse
Other
47 stars 30 forks source link

Fix implementation of Snowflake's TO_TIME/TO_TIMESTAMP functions #1218

Closed vil1 closed 3 days ago

vil1 commented 1 week ago

Improve the way TO_TIME and TO_TIMESTAMP are translated.

github-actions[bot] commented 1 week ago

Coverage tests results

456 tests  +1   419 ✅ +1   4s ⏱️ ±0s   6 suites ±0    37 💤 ±0    6 files   ±0     0 ❌ ±0 

Results for commit e05db34b. ± Comparison against base commit 0f06d166.

This pull request removes 9 and adds 10 tests. Note that renamed tests count towards both. ``` com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_to_time/test_to_time_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_to_time/test_to_time_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_try_to_date/test_try_to_date_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_try_to_date/test_try_to_date_3.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/to_timestamp_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/dayname/test_dayname_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/monthname/test_monthname_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/test_date_trunc_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/test_date_trunc_3.sql ``` ``` com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_to_time_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_to_time_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_try_to_date_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_try_to_date_3.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/to_timestamp_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/to_timestamp_variable_format.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/dates/test_date_trunc_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/dates/test_date_trunc_3.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/dates/test_dayname_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/dates/test_monthname_1.sql ```

:recycle: This comment has been updated with latest results.