search

databrickslabs / remorph

Cross-compiler and Data Reconciler into Databricks Lakehouse
Other
21 stars 13 forks source link

Support CTAS in TSQL Grammar and add more comparison operators. #545

Closed bishwajit-db closed 3 weeks ago

bishwajit-db commented 1 month ago

Support CTAS in TSQL Grammar. Support for !=, !<, !> operators

github-actions[bot] commented 1 month ago

Coverage tests results

401 tests  ±0   381 :white_check_mark: ±0   4s :stopwatch: -1s   2 suites ±0     0 :zzz: ±0    2 files   ±0    20 :x: ±0 

For more details on these failures, see this check.

Results for commit 37c654a7. ± Comparison against base commit ec13a9e5.

:recycle: This comment has been updated with latest results.

bishwajit-db commented 1 month ago

@jimidle, while experimenting with stored procedure I ran into some issues with DDL. So added these changes to move ahead. Could you please take over the PR so that the changes can be included along with the DDLBulider for TSQL?

nfx commented 4 weeks ago

@bishwajit-db Jim will pick it up after vacation

jimidle commented 4 weeks ago

@bishwajit-db Jim will pick it up after vacation

The CREATE TABLE grammar will need quite a lot of changes, as it is still in the style of the original grammar we had, but the operator stuff looks fine in the current way they are being handled - those operators were obviously missed originally. That grammar form is possibly going to change, but I will make sure to include these operators if I change it.

jimidle commented 4 weeks ago

@nfx This PR can be merged as-is, as the operators were just missing from the original grammar and the changes to CREATE TABLE are innocuous. There will be significant changes to CREATE once I start on it as there is more missing than CTAS and as CREATE xxx is expressed it will cause ANTLR to do a lot of lookahead to predict the correct alts. Changing the whole of create is a series of additional PRs.