databrickslabs / remorph

Cross-compiler and Data Reconciler into Databricks Lakehouse
Other
28 stars 16 forks source link

[FEATURE]: Fill in all rule names and translations for TSQL error strategy #759

Open jimidle opened 1 month ago

jimidle commented 1 month ago

Is there an existing issue for this?

Category of feature request

Other

Problem statement

The file TSqlErrorStrategy.scala contains lists of keywords and rule names, with a human friendly translations. However, not all rules have been translated so sometimes an error message will be less specific than it could be when it describes what it is trying to parse.

Proposed Solution

Go through all the rule productions in TSqlParser.g4 add a human friendly translation for rules where it makes sense to do so.

Additional Context

Not all rules need to have a translation as very low level rules do not usually add anything to the explanation of what is being parsed. However, it does not harm to over specify here, so adding rule translations will not be incorrect. This would be a good task for someone who is just starting out learning the ANTLR grammars as it will involve reading the grammar from top to bottom and checking with the lexer tokens.