Closed sriram251-code closed 2 months ago
As per comment, thes necessary changes were done
I have added the antlr grammar to parse the commands with "!" BANG prefix. This should ensure that this will get captured in unresolved CommandIR. Please le me know if you want me to add explecit test case for it.
Just requires the extra simple tests and to resolve the transpiler test merge conflict and we are good.
@jimidle as disscussed please review :) thanks.
closes #165
In the Snowflake code, the setting option
!set exit_on_error=true
caused remorph to return an error. We have now modified remorph to comment out this setting, treating it as a command. As a result, instead of producing an error, the output will now append '--' before the command . ex: Snowflake input sql :!set exit_on_error=true
Remorph output:-- !set exit_on_error=true
In Snowflake, passing a parameter such as
select emp_id from abc.emp where emp_id = &ids;
caused remorph to give an error due to the unexpected&
symbol. We have now implemented a change to convert&
to its Databricks equivalent$
which represents parameters, resolving this issue. ex: Snowflake input SQL:select emp_id from abc.emp where emp_id = &ids;
Remorph output:select emp_id from abc.emp where emp_id = $ids;