search

databrickslabs / remorph

Cross-compiler and Data Reconciler into Databricks Lakehouse
Other
28 stars 16 forks source link

TSQL: Implement grammar for CREATE DATABASE and CREATE DATABASE SCOPED OPTION #788

Closed jimidle closed 4 weeks ago

jimidle commented 1 month ago

The TSQL grammar for CREATE DATABASE and CREATE DATABASE SCOPED OPTION was not consistent with the TSQL documentation. Here we correct the grammar errors.

While it was originally my intention to implement these all the way through to code gen, the DDL needs some serious work, and I would rather implement the grammar for it all in a series of grammar only PRs, then come back through and implement all the way to codegen in a subsequent set of PRs. The reason being that as each DDL statement is fixed at the grammar level, all the other DDL statements will gradually simplify at the same time and I do not wish to keep changing grammar then have to tweak previously defined code gen.

github-actions[bot] commented 1 month ago

Coverage tests results

401 tests  ±0   154 :white_check_mark: ±0   4s :stopwatch: -1s   2 suites ±0     0 :zzz: ±0    2 files   ±0   247 :x: ±0 

For more details on these failures, see this check.

Results for commit 7c5f271f. ± Comparison against base commit a01a719b.

:recycle: This comment has been updated with latest results.