Fix "manual" creation of URL with GET parameters

databrickslabs / splunk-integration

Databricks Add-on for Splunk

https://splunkbase.splunk.com/app/5416/

Other

26 stars 18 forks source link

Fix "manual" creation of URL with GET parameters #10

Closed alexott closed 3 years ago

alexott commented 3 years ago

The current method of creating URL has one big problem - it doesn't do urlencode of passed parameters, so it will lead to errors if key name or value contain special characters, such as, &, +, etc.

This PR fixes this problem by using built-in functionality of the requests library that can automatically urlencode these parameters: https://docs.python-requests.org/en/latest/api/#requests.request

arunpamulapati commented 3 years ago

Assigned this PR for review by @dveuve