CI/CD overhaul - Githubissues

databrickslabs / tempo

API for manipulating time series on top of Apache Spark: lagged time values, rolling statistics (mean, avg, sum, count, etc), AS OF joins, downsampling, and interpolation

https://pypi.org/project/dbl-tempo

Other

306 stars 52 forks source link

CI/CD overhaul #403

Closed jtisbell4 closed 2 months ago

jtisbell4 commented 5 months ago

Major changes to test and build infrastructure, predominantly related to tox:

tox environments correctly configured
GH actions simplified/refactored to exclusively use tox
Officially dropped support for DBR < 11.3
Moved DBR-specific requirements into python/tests/requirements
Made SparkSession initialization dynamic in test class setup

A few minor changes in python/tempo:

Fixed if statement in TSDF.withRangeStats
Removed event_time column assumption and made Z-ORDER attempt contingent on optimizationCols in io.write

R7L208 commented 4 months ago

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn]

Looks like some tests are still failing with this error. Did the fix for this get merged into master?

jtisbell4 commented 4 months ago

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn]

Looks like some tests are still failing with this error. Did the fix for this get merged into master?

@R7L208 Not yet. @tnixon and I had a conversation about this issue on Slack. Not sure what he wants to do to fix it.

tnixon commented 4 months ago

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn] Looks like some tests are still failing with this error. Did the fix for this get merged into master?

@R7L208 Not yet. @tnixon and I had a conversation about this issue on Slack. Not sure what he wants to do to fix it.

I was working on a fix for this but got distracted. Let me see how quick I can push that change.

github-advanced-security[bot] commented 4 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.