databrickslabs / ucx

Automated migrations to Unity Catalog
Other
217 stars 75 forks source link

[BUG]: `create-missing-principals` does not enforce role uniqueness on AWS #2336

Closed nfx closed 2 weeks ago

nfx commented 1 month ago

Is there an existing issue for this?

Current Behavior

currently we use UCX-ROLE as the default role name, but we do receive https://github.com/databrickslabs/ucx?tab=readme-ov-file#create-missing-pricipals-command-aws-only

Expected Behavior

append metastore name as the ucx role suffix

Steps To Reproduce

No response

Cloud

AWS

Operating System

macOS

Version

latest via Databricks CLI

Relevant log output

No response

nfx commented 3 weeks ago

Do not use one predefined name for anything cloud-related - see the relevant fix for locations - https://github.com/databrickslabs/ucx/commit/505fe1e9d363245f122561263dfc8bc4ae8056f9