databridgevt / covid19

Data analysis of the 2020 COVID-19 pandemic
MIT License
6 stars 2 forks source link

Mak's Map of US #60

Closed chendaniely closed 4 years ago

chendaniely commented 4 years ago

We'll clean up the code in a few phases.

Separate out mapping code

You have some code from your Spring risk factor keywords mixed in with your mapping code, so let's separate them first

  1. Create a new folder, us_map that is a sibbling folder to max, i.e., should be analysis/db/us_map.
  2. Move your US map code into the us_map folder, this includes your scripts, ipynb files, and data files. I seems like the only files that should be in the max folder would be the Test_kits.py file and load_data.py file
  3. commit and push the changes after you move all the files into separate folders

Separate map data from map code

You have your data mixed in with all your code, you need to move your data into the appropriate folder in ./data/db/.

  1. Make a folder ./data/db/original/maps and move your shapefiles, excel sheets, csv, etc files in there.
  2. Commit/push you changes after you move your data.
  3. The datasets paths have changed, you need to then run your code so your code can load the data from the correct directory. There here() function in pyprojroot should help you with this (see the code comment)
  4. The code you are working with should run from to to bottom just like before

Remove test and extra scripts

There are a lot of files that do not seem relevant anymore. I don't think you're using any of the notebooks.

  1. Delete the scripts and notebook files that were your test scripts that are not part of your final analysis.
    • If you're worried about loosing code and want a way to reference back to code in the future, write a good commit message after you delete your files so you can always use github to search through past commits and look at old files.
  2. commit and push changes