search

databus23 / helm-diff

A helm plugin that shows a diff explaining what a helm upgrade would change
Apache License 2.0
2.68k stars 279 forks source link

Don't output help on install #621

Closed z0rc closed 3 months ago

z0rc commented 4 months ago

This isn't a real test, and it produces noise on each install, which isn't desired in case of running under CI environment.

Fixes https://github.com/databus23/helm-diff/issues/605.

yxxhero commented 3 months ago

@z0rc how do we make sure that helm-diff can work well? maybe we can use > /dev/null to drop the output of diff -h?

z0rc commented 3 months ago

@yxxhero by testing it during development/release process. I don't think testing after install is helpful for end user. Also I didn't found any other plugin that does this kind of testing nowadays. There is https://github.com/technosophos/helm-template from which install-binary.sh was copied, but it's unmaintained.

yxxhero commented 3 months ago

ok. make sense.

yxxhero commented 3 months ago

@z0rc have a try.

z0rc commented 3 months ago

Works as expected. Thanks.