search

datacamp-content / courses-introduction-to-shell

Introduction to Shell by Greg Wilson
Other
48 stars 47 forks source link

Fixes based on user feedback 2017-12-15 #101

Closed gvwilson closed 6 years ago

gvwilson commented 6 years ago

Lots of small fixes based on user feedback - review would be greatly appreciated. (Another PR like this will happen early next week.)

sumedh10 commented 6 years ago

@gvwilson Since you pushed a new version of sqlwhat_ext, do the SCTs need to be reviewed as well?

gvwilson commented 6 years ago

The change to shellwhat_ext is supposed to report flags that the user provides that aren't supposed to be there. There's only a few cases where this comes up, and I think I've checked all of them. If you can re-run the exercises where the body of the call to test_cmdline has changed, I'd appreciate it - I'll give you a shout as soon as I'm able to get a clean build (see #pm-teach discussion with Goran this morning).

yashasroy commented 6 years ago

@gvwilson @sumedh10 Any update on this?

gvwilson commented 6 years ago

I can no longer see the unix shell course in the dashboard, even when I "show all".

sumedh10 commented 6 years ago

@gvwilson Is this ready for review?

gvwilson commented 6 years ago

Yes please - there are more to come, but let's get this in as soon as we can.

sumedh10 commented 6 years ago

@gvwilson I made all the changes we spoke about. Waiting to hear back from Martijn regarding adding/deleting exercises.