datacamp / Hacker-Stats-in-Python-Live-Training

Live Training Session: Hacker Stats in Python
12 stars 8 forks source link

Part 2 Review #3

Closed jsaddlemyer closed 4 years ago

jsaddlemyer commented 4 years ago

Hi Justin,

First off, great work. I really wish I had something similar when I first learned stats. Structurally I think it has a nice flow, a good overview of the previous section, and the concepts are well explained. Below are my only comments.

Edits/suggestions (suggested adaptation in bold):

justinbois commented 4 years ago

Thanks for the kind work, @jsaddlemyer . A few points:

  1. The Pearson correlation formula is correct as written.
  2. Great catch on the NHST. Fixed.
  3. @adelnehme suggested not defining classes, as not all learners will be familiar with it. I wasn't sure how to do it, so I left the classes in there. I ended up coming up with a clean way to do it without classes using dictionaries and a function, so I updated the notebook to that effect.

I'll generate the student notebook soon.

jsaddlemyer commented 4 years ago

Hi @justinbois,

1) My apologies, I think I misread the description below regarding the equation. 3) I think the way you had introduced and described classes in the notebook was already clear, even to students not totally familiar with them. But indeed, the dictionary/function approach is a great alternative and should make it more accessible to students.

Thanks again!

Justin