datacamp / pythonwhat

Verify Python code submissions and auto-generate meaningful feedback messages.
http://pythonwhat.readthedocs.io/
GNU Affero General Public License v3.0
69 stars 31 forks source link

Base pythonwhat on protowhat #373

Closed hermansje closed 5 years ago

hermansje commented 5 years ago

Use https://github.com/datacamp/protowhat/pull/32 to have less duplicate code and more compatibility for extensions of the xwhat ecosystem.

To review, it might be helpful to filter commits instead of reviewing everything at once

This shows the main refactor.

codecov[bot] commented 5 years ago

Codecov Report

Merging #373 into master will decrease coverage by 0.17%. The diff coverage is 94.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   94.81%   94.64%   -0.18%     
==========================================
  Files          27       26       -1     
  Lines        2141     1979     -162     
==========================================
- Hits         2030     1873     -157     
+ Misses        111      106       -5
Impacted Files Coverage Δ
pythonwhat/checks/check_wrappers.py 100% <100%> (ø)
pythonwhat/checks/check_object.py 100% <100%> (ø)
pythonwhat/test_funcs/test_object.py 100% <100%> (ø) :arrow_up:
pythonwhat/test_funcs/__init__.py 100% <100%> (ø) :arrow_up:
pythonwhat/signatures.py 100% <100%> (ø) :arrow_up:
pythonwhat/test_funcs/test_function.py 100% <100%> (ø) :arrow_up:
pythonwhat/converters.py 100% <100%> (ø) :arrow_up:
pythonwhat/test_funcs/test_object_accessed.py 100% <100%> (ø) :arrow_up:
pythonwhat/checks/has_funcs.py 96.21% <100%> (ø)
pythonwhat/checks/check_function.py 100% <100%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50bc6f1...6a03a48. Read the comment docs.