datacamp / rdocumentation-2.0

📚 RDocumentation provides an easy way to search the documentation for every version of every R package on CRAN and Bioconductor.
https://rdocumentation.org
MIT License
285 stars 44 forks source link

[CT-3469] Refactor: add autocomplete to navbar, fix redirect #124

Open ben-brooker opened 2 years ago

ben-brooker commented 2 years ago

Ticket

Making function suggestions redirect straight to topic page instead of global search results page.

Was going to do the same for packages suggestions, however there are some broken links so a risk that the suggestion will link to a "oops, page not found".

Changes

Pictures

Before (Desktop):

Screenshot 2022-07-12 at 16 02 31

After (Desktop):

Screenshot 2022-07-12 at 16 06 11

Before (Mobile):

Screenshot 2022-07-12 at 16 03 38

After (Mobile):

Screenshot 2022-07-12 at 16 03 26
ztsorojev commented 2 years ago

Here I think we should remove this, and just pick the 5 items with the highest score that start with what the user entered: https://github.com/datacamp/rdocumentation-2.0/blob/bd0936d18661797a609c866984599d36f30ea89f/components/Autocomplete.tsx#L44-L45

So something similar to this:

     const relevantPackages = packages?.sort((pA, pB) => pB.score-pA.score)
                             ?.filter(p => p.toLowerCase().startsWith(query.toLowerCase()))
                             ?.slice(0, 5);